[pull] master from ghostunnel:master#72
Merged
Merged
Conversation
Use a temporary keychain via the security CLI instead of the broken certstore.Import() API (which calls SecPKCS12Import but never persists the identity with SecItemAdd). Remove the now-unused keychain-helper Go binary. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add macOS keychain identity integration test
Release the SecPolicyRef from SecPolicyCreateSSL and the CFErrorRef from SecTrustEvaluateWithError, both of which were previously leaked on every call to CertificateChain. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add a mutex to macIdentity to protect the lazy initialization of SecKeyRef and SecCertificateRef handles in getKeyRef/getCertRef. Without this, concurrent TLS handshakes could race on the nil check, causing duplicate CGo handle allocations where the losing write leaks its handle. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use %w instead of %v so that callers can use errors.Is/errors.As to inspect the underlying X.509 or PKCS7 parse errors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add a mutex to macIdentity to protect the lazy initialization of SecKeyRef and SecCertificateRef handles in getKeyRef/getCertRef. Without this, concurrent TLS handshakes could race on the nil check, causing duplicate CGo handle allocations where the losing write leaks its handle. Uses double-checked locking so the mutex is only contended on the very first call — subsequent calls return on the fast path without acquiring the lock. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add missing godoc for TLSConfigSourceFromACME - Fix grammar: "a OPA" → "an OPA" in Policy interface doc - Fix stale comment on GetServerConfig: said "false is returned" but return type is (TLSServerConfig, error), not bool Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Fix small bugs found by Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )